Resurrect BrowserSelectorTest #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzaibj
reviewed
Apr 28, 2021
common/src/test/java/com/microsoft/identity/common/BrowserSelectorTest.java
Show resolved
Hide resolved
shahzaibj
reviewed
Apr 28, 2021
common/src/test/java/com/microsoft/identity/common/BrowserSelectorTest.java
Show resolved
Hide resolved
shahzaibj
approved these changes
Apr 28, 2021
shoatman
approved these changes
Apr 28, 2021
AdamBJohnsonx
approved these changes
Apr 28, 2021
AdamBJohnsonx
added
the
No-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking one of the pr pipeline. (The reason is that Mockito-android cannot mock final class).
I'm switching them to Robolectric.
Note: addResolveInfoForIntent() is already deprecated, but I can't find how to get the alternative work (since it requires ComponentName, ComponentName requires class name and we're not providing one here). I didn't want to spend too much time on it so I just pick the deprecated one for now.